-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Smooth Continuum in FastSpecFit #171
Comments
Thanks for the specific examples, @Ragadeepika-Pucha. One quick request for the future: if you could provide not just the targetid, but also the specprod (fuji vs iron vs jura) and the survey, program, and healpix, then I'll much more easily be able to find the exact spectra you're working with. The long-standing issues with the "smooth continuum" algorithm together with the line-fitting speed-ups facilitated by @jdbuhler, inspired me to build a brand new algorithm: In essence, I now carry out an emission-line modeling step before continuum-fitting which considers both a narrow and broad+narrow line-model. A small subset of major lines are fit in "patches" (but with line-widths and line-centers still constrained across patches, using reasonable, physical assumptions), and the local continuum is taken to be a simple line. A conservative decision is then made about how much to mask all the lines, but particularly the broad Balmer lines. Here's one of the optional QA figures from the first object in your list, You can see that the initial fit of the Halpha+[NII] complex is quite good, which leads to the following line-mask (orange=emisison-line pixels; blue=local continuum pixels): The final fit looks quite excellent, IMHO: Comparing our respective fits to the H-alpha region, I find Some quick thoughts:
Looking forward to hearing your thoughts and, in the meantime, I'll continue testing out the new algorithm. |
Hi @moustakas , it seems that the screenshot from Raga's post was for TARGETID=39633105035725300 (and not the first number she listed) as it resembles this iron version from the prospect link. I note that the other two TARGETIDs (39633010890377403, 39627805847195825) including the one you fit above have very clear double-peaked narrow lines. Fitting them as a single component might slightly affect the BL fit but probably not too strongly because the BL components are quite prominent. |
Here's my updated fit for Note that fitting multiple components to different lines (e.g., Halpha) is outside the scope of the current code, but functionality that I'm thinking of adding longer-term. |
Hi @moustakas @stephjuneau - I am sorry for the delay in getting back to you. I rechecked the fits from both TARGETID: 39633010890377403 This is the first case that you showed with detailed patches and masked pixels.
This is similar to the FastSpecFit new estimates! |
@moustakas @stephjuneau
There are two separate yet related issues that I found with the smooth continuum in FastSpecFit:
Example TARGETs that are affected in this way:
39633010890377403
,39633105035725300
,39627805847195825
. I could only find a handful of such cases.Example TARGETs that are affected in this way:
39627908800577649
,39627770271109086
,39632996646520846
,39633114426773787
,39633453762741009
.The text was updated successfully, but these errors were encountered: