merge two multiprocessing loops into one #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a long-overdue structural change which merges the two multiprocessing pools--one for I/O and the second one for fitting---into a single pool.
In addition to being more efficient (and cleaner, code-wise), it sets the stage for easily switching between Python's
multiprocessing, which is disfavored at NERSC and MPI's MPIPoolExecutor, which is favored.It also means that the fitting doesn't have to wait for the I/O to finish, which was getting unruly with healpixels containing many thousands of spectra. Plus the Galactic dust calculations were (finally!) vectorized, again for efficiency.
Finally, I restored the
stackfitoption of fitting stacked, single-camera spectra, which had been broken for some time.