add additional filter curves

[moustakas]

[WIP]

Additional filters are needed for a variety of scientific DESI analyses.

[dstndstn]

The intermediate band filters are Suprime, not HSC, aren't they?

…

On Thu, Jul 13, 2023, 10:25 p.m. Moustakas ***@***.***> wrote: [WIP] Additional filters are needed for a variety of scientific DESI analyses. ------------------------------ You can view, comment on, or merge this pull request online at: #78 Commit Summary - 7365df3 <7365df3> add HSC intermediate-band (IB) filters - bed785d <bed785d> update group names - 96877ff <96877ff> add legend_ncols optional input - d3ca910 <d3ca910> add png - 97b1507 <97b1507> fix test - 728a101 <728a101> test against python 3.10 and 3.11 - 647c98f <647c98f> add galex - c0c29e4 <c0c29e4> remove obsolete travis config file File Changes (26 files <https://github.com/desihub/speclite/pull/78/files>) - *D* .travis.yml <https://github.com/desihub/speclite/pull/78/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485> (136) - *A* docs/_static/galex.png <https://github.com/desihub/speclite/pull/78/files#diff-43a9c43f46b22c688b61da2d3d449a713d193ead50c0761d488a1eee546a70dc> (0) - *A* docs/_static/hscib.png <https://github.com/desihub/speclite/pull/78/files#diff-885b705894bc37809ed59391dded2f730a9c1d0dfafb8e72962fc022ee209c22> (0) - *M* docs/filters.rst <https://github.com/desihub/speclite/pull/78/files#diff-425d77e64ba190beb0e0b8066b0201e5fa798f148fb9d673e4f4e0827228e9f1> (33) - *A* speclite/data/filters/galex-fuv.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-2ff72ef9347fc114d0f76713c98d6ccd7914d4860423d9871aece4d444c0cecf> (30) - *A* speclite/data/filters/galex-nuv.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-57740cfb8fd412d786887c800cec19fb21752909c3627d7c73f0f1f06090cdd2> (40) - *A* speclite/data/filters/hscib-IA427.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-b790431ddc84840304b27d8376972ccee66cce70fa0b51a87c45f361cedbdd3e> (52) - *A* speclite/data/filters/hscib-IA445.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-d676f22df144c2e6695ded8dcdfe8e66e969bd3ade4ce5d62437a42c310cb50b> (55) - *A* speclite/data/filters/hscib-IA464.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-ad0bbdf0b19d65ef7adc18f709800157a031e4559a40965660667404b314be76> (41) - *A* speclite/data/filters/hscib-IA484.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-8aacb2e39f14265484ec5886056df76ca08b7e95df925993bfa26ee6fc431804> (45) - *A* speclite/data/filters/hscib-IA505.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-350b3a611c93e8aa6db095220be7cb56a32bb5345e3b8422dee0513b3d9f6f13> (47) - *A* speclite/data/filters/hscib-IA527.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-b03df3224f004138238c3229fbe909f6f4bb7cb443a9dcef61f21b30f3c77684> (48) - *A* speclite/data/filters/hscib-IA550.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-267c1466419c5a17cade37389c942d05da21a9b67a578ee99615c571833c6f3c> (53) - *A* speclite/data/filters/hscib-IA574.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-d2bda41ca1bd9c10b5aa3ade246f935dfff9c5e186bd2fa0edde69babe8fb89b> (55) - *A* speclite/data/filters/hscib-IA598.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-5e17a75ca78ce8e4dc4cca776060e613e3e8886402678045bfd3dc9e961c6496> (52) - *A* speclite/data/filters/hscib-IA624.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-2e2bd0130b27d5f41c1b589ce2aa5247c8e54dfa87db43e3d1b472c297ab1762> (46) - *A* speclite/data/filters/hscib-IA651.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-416128d7840291ce464a7010236c1e9a05e4c75ba17c0198a087213f5f321e6c> (48) - *A* speclite/data/filters/hscib-IA679.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-4219ff0d656d7e2f2b9efc56fb5625daa8b96d031ec1cd67e16590cb2151766d> (52) - *A* speclite/data/filters/hscib-IA709.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-f551b34548e4a3fd378cb5d8cd18eeb2ca78c6bb4dc3fb2ed0c6af3c9dea1a31> (46) - *A* speclite/data/filters/hscib-IA738.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-996fd3987c6e1b66c0c91469097a0f3a1d3bbc0957f7eef9d2c4d8404dcb4241> (45) - *A* speclite/data/filters/hscib-IA768.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-ea3509505b6fd2b2ebc50784ce9b3946e2185c06fbcb2492046da61683454943> (41) - *A* speclite/data/filters/hscib-IA797.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-380d96d540919d0b45d8cff384fbdb0d8e21c4054572dbd92d0bf1e4c707f302> (45) - *A* speclite/data/filters/hscib-IA827.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-aa016646e98aa8cc9ee029ff959053538523a9c8efc54178f53ff007c982cc99> (38) - *A* speclite/data/filters/hscib-IA856.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-0acd0f0517aab55620d455b9258bbb1642213dd703e922bed1a6fafbb4f52757> (71) - *A* speclite/data/filters/hscib-IA907.ecsv <https://github.com/desihub/speclite/pull/78/files#diff-a4a3614132adbc750eefd0334241a27c1321763bce7ad292ec5fec53f04bed67> (39) - *M* speclite/filters.py <https://github.com/desihub/speclite/pull/78/files#diff-8220e87fb237013af940ba2dcb551111497cfab453bbaabda6ed6c3216cac880> (26) Patch Links: - https://github.com/desihub/speclite/pull/78.patch - https://github.com/desihub/speclite/pull/78.diff — Reply to this email directly, view it on GitHub <#78>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIEH7KABSKCSNNUEMDWZEDXQCUZJANCNFSM6AAAAAA2JXGAGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[moustakas]

The intermediate band filters are Suprime, not HSC, aren't they?

Indeed, @dstndstn.

@dkirkby is there a convention you would like me to follow with respect to the filter names? For example, for the intermediate-band filters would you like the prefix (and filter group) to be subaru-*, suprimecam-*, or something different?

Also, is it possible for the same filter to belong to two different groups? For example, I would like to assemble a cosmos2020-* filter group of 39(!) bandpasses, but many of them will belong in other groups. Or would you like the "groups" to be restricted to the same camera / telescope system?

Other opinions?

[dkirkby]

The API for loading a group of filters is load_filters, which is quite flexible since you can always specify an arbitrary list of filter names. It also supports a wildcard like "sdss-*" which is much less flexible. I suggest you group names by prefix in whatever way is likely to be the most useful default for users. The existing prefixes generally group bands that were in use on the same instrument at the same time.

[weaverba137]

As discussed in #79, we will close this PR and open a new PR that contains only the filter updates, since the test infrastructure updates are superseded by #79.