Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure updates #81

Merged
merged 11 commits into from
Sep 14, 2023
Merged

Infrastructure updates #81

merged 11 commits into from
Sep 14, 2023

Conversation

weaverba137
Copy link
Member

This PR makes some relatively minor updates to the package infrastructure, with the hope of not disrupting ongoing work on some filter updates, etc.

Copy link
Member

@moustakas moustakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. My only minor comment / question (but perhaps for a separate PR) is whether we want to start testing against a newer version of Python than 3.8.

@weaverba137
Copy link
Member Author

@moustakas, great question. Let me at least experiment with that on this PR, but if I find significant problems, I'll restore the current test suite and defer that to another PR.

@weaverba137
Copy link
Member Author

Some of the more recent versions of Astropy have different ordering when printing units, so I don't think we can test the most recent Astropy on this PR. Still the test matrix will move forward.

@weaverba137
Copy link
Member Author

I've nudged the test versions forward a little bit. Astropy > 5.0 introduces some ordering changes in printing units that will need some fixes in subsequent PRs.

@weaverba137 weaverba137 merged commit ba24736 into main Sep 14, 2023
104 checks passed
@weaverba137 weaverba137 deleted the minor-infra-updates branch September 14, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: Stop using ci-helpers in appveyor.yml Infrastructure updates notice from Astropy Project
2 participants