Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2023 versions of LSST filter curves #84

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Add 2023 versions of LSST filter curves #84

merged 5 commits into from
Feb 15, 2024

Conversation

dstndstn
Copy link
Contributor

There's a new mirror baseline (Silver coatings), so add 'lsst2023' filter group. Also update docs for lsst2016 group.

moustakas
moustakas approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@moustakas moustakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thank you. We should probably move to ECSV version 1.0 for the filter files (vs 0.9, here), but this isn't a blocking factor.

One request: please update the change log (under pending version 0.19) before merging.

@dstndstn dstndstn merged commit a5b1bed into main Feb 15, 2024
104 checks passed
@dstndstn dstndstn deleted the lsst-2023 branch February 15, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moustakas moustakas moustakas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstndstn @moustakas