Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in preparation for next release #92

Merged
merged 12 commits into from
Aug 5, 2024
Merged

Conversation

weaverba137
Copy link
Member

@weaverba137 weaverba137 commented Aug 2, 2024

@weaverba137 weaverba137 self-assigned this Aug 2, 2024
@weaverba137
Copy link
Member Author

Additional commentary: I tried to make as few changes as possible in this PR, and I think this is a release candidate for v0.20. However, I recommend that subsequent to this PR and tagging v0.20 that a major overhaul of the package infrastructure be performed, e.g. removing astropy_helpers, minimizing the use of setup.py. This isn't hard, since there are plenty of examples already in the Astropy and DESI ecosystems.

@weaverba137
Copy link
Member Author

Bonus: I have been able to fix #25. For both #25 and #34, the issue was that FilterSequence.pad_spectrum was not passing the axis or method keywords to FilterResponse.pad_spectrum. That's all!

Copy link
Member

@dkirkby dkirkby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@weaverba137
Copy link
Member Author

Thank you @dkirkby. I'll leave this open longer in case anyone wants to take a look: @segasai, @moustakas, @araichoor.

Copy link
Contributor

@segasai segasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that you added the previously failing example to the tests, so it looks good to me in terms of fixing #34
Thanks!

@weaverba137
Copy link
Member Author

Thank you everyone, merging and tagging momentarily.

@weaverba137 weaverba137 merged commit 9b17e49 into main Aug 5, 2024
110 checks passed
@weaverba137 weaverba137 deleted the updates-for-kibo branch August 5, 2024 17:05
@moustakas
Copy link
Member

Could v0.20 be installed at NERSC, please?

module spider speclite

--------------------------------------------------------------------------------------------------------------------
  speclite:
--------------------------------------------------------------------------------------------------------------------
     Versions:
        speclite/main
        speclite/master
        speclite/v0.13
        speclite/v0.15
        speclite/v0.16
        speclite/v0.17
        speclite/v0.18
        speclite/v0.19

@weaverba137
Copy link
Member Author

Done, but only for desiconda/20240425-2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants