Slow tests fail on missing repository

[webstech]

Two of the slow tests are failing on expect(result).toBe(GitError.HTTPSAuthenticationFailed). The result is 8 instead of 3. This happens at line 50 and 115. A dump of the result says the repo is not found:

{"exitCode": 128, "stderr": "Cloning into '.'...
    remote: Repository not found.
    fatal: repository 'https://github.com/shiftkey/repository-private.git/' not found
    ", "stdout": ""}

@shiftkey Did you delete the repo?

[shiftkey]

@shiftkey Did you delete the repo?

Nope, it still exists.

[webstech]

The failing tests appear to be related to the newish git credential manager. The test setup tries to use the GIT_ASKPASS env var to drive a failed authorization. Setting GCM_TRACE=1 shows the new credential manager is being used (with my login). Tried to set some local config to override globals but it seems I do not know git well enough to configure this.

git system config says:

credential.helper=manager-core

git global config says:

credential.helper=wincred

need to look into why wincred is still set.

Any ideas on how to configure this to force HTTPSAuthenticationFailed vs HTTPSRepositoryNotFound (due to valid login)? Replacing the private shiftkey repo with my own private repo works due to the valid login. ie, the clone works but the expects fails.

[niik]

As of #564 we no longer do network operations during tests so I'm going to close this.