Avoid network ops in tests #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…then fetch will work
sergiou87
previously approved these changes
May 21, 2024
sergiou87
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #563 but broken out to be reviewed separately.
While working on #563 I noticed that we were doing actual clone's (or attempting to) of repositories hosted online. Several of these repositories are completely outside of the current team's control. This is both risky and unnecessary.
I've updated these tests to either a) not use clone at all when it doesn't have to, b) clone a local repository over the file:// protocol when the http protocol isn't required or c) clone using a fake Git server running locally.
I've also removed some tests that don't appear to be testing any dugite-specific functionality at all.