Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker version bump to unpin requests #9614

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Jul 5, 2024

Ticket

https://hpe-aiatscale.atlassian.net/browse/MD-415

Description

Python requests library update broke the docker python library. docker has since fixed the issue. See: docker/docker-py#3257

Test Plan

CI passes

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2024
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 10b363b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6688633bd56a830008ab6537

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.88%. Comparing base (0a57cde) to head (10b363b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9614      +/-   ##
==========================================
- Coverage   52.89%   52.88%   -0.01%     
==========================================
  Files        1255     1255              
  Lines      153086   153086              
  Branches     3230     3230              
==========================================
- Hits        80971    80959      -12     
- Misses      71964    71976      +12     
  Partials      151      151              
Flag Coverage Δ
backend 43.99% <ø> (-0.03%) ⬇️
harness 72.76% <ø> (ø)
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@MikhailKardash MikhailKardash marked this pull request as ready for review July 5, 2024 21:24
@MikhailKardash MikhailKardash requested a review from a team as a code owner July 5, 2024 21:24
@MikhailKardash MikhailKardash merged commit c28545d into main Jul 8, 2024
116 of 121 checks passed
@MikhailKardash MikhailKardash deleted the docker_dependency branch July 8, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants