chore: re-split code editor #9899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the code editor was being included in the main app bundle. While you can indicate that a component is meant to be split with `React.lazy`, if any code elsewhere imports the code statically the code is unsplit. We wrap the code split component and ban other imports using eslint to prevent this from regressing.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9899 +/- ##
==========================================
- Coverage 54.70% 50.58% -4.13%
==========================================
Files 1262 940 -322
Lines 156760 127375 -29385
Branches 3597 3595 -2
==========================================
- Hits 85762 64430 -21332
+ Misses 70867 62814 -8053
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
none
Description
This fixes an issue where the code editor was being included in the main app bundle. While you can indicate that a component is meant to be split with
React.lazy, if any code elsewhere imports the code statically the code is unsplit. We wrap the code split component and ban other imports using eslint to prevent this from regressing.Test Plan
Frontend bundle size should be reduced. visiting places where the code editor is visible should show a spinner while the code editor is loading
Checklist
docs/release-notes/See Release Note for details.