feat : 예매대기 등록 API application layer 구현 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦞 Test Coverage Report
|
ssssujini99
approved these changes
Dec 24, 2023
There was a problem hiding this comment.
생성자에서 각 부분 검증로직 잘 구현하신 것 같아요!! 꼼꼼하게 다 잘 하신듯 👍🏻
There was a problem hiding this comment.
도메인 단위테스트도 각 예외까지 꼼꼼히 작성하신거 굿!!! 👍🏻👍🏻
| WaitingBooking waitingBooking = WaitingBooking.of(user, request.seatCount(), request.seatIds()); | ||
| waitingBookingRepository.save(waitingBooking); | ||
|
|
||
| return waitingBooking; |
There was a problem hiding this comment.
왜 반환형이 waitingBooking인지 궁금합니다!
There was a problem hiding this comment.
아 밑에 WaitingBookingFascade 보고 바로 이해했습니다!
There was a problem hiding this comment.
예약대기 시 UserService 를 가져와야 해서 fascade 패턴을 이용하셨군요!
너무 잘 구현하신 것 같아요 굿굿~!!
🦞 Test Coverage Report
|
|
퍼사드 패턴을 활용한 게 깔끔한 레이어를 유지해준 것 같아서 좋습니다! |
EunChanNam
added a commit
that referenced
this pull request
Jan 15, 2024
* feat: ValidationException 정의 * fix: User 엔티티 기본 생성자 public 으로 전환 * feat: WaitingBookingErrorCode 정의 * feat: WaitingBooking 생성로직 구현 * feat: 예매대기 등록 API 요청, 응답 DTO 구현 * feat: 예매대기 엔티티 생성 서비스로직 구현 * feat: 예매대기 등록 퍼사드로직 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 무엇을 개발했나요?
🍸 무엇을 집중적으로 리뷰해야할까요?