feat : 예약 최종 등록 로직 구현 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkangh00n
approved these changes
Jan 1, 2024
Comment on lines
+38
to
+58
|
|
||
| @Transactional | ||
| public Reservation validateReservationAndSaveIsEmpty(CreateReservationRequest request) { | ||
| ReservationTime reservationTime = reservationTimeRepository.findByIdWithShop( | ||
| request.reservationTimeId()). | ||
| orElseThrow(() -> new NotFoundCustomException(NOT_EXIST_TIME)); | ||
|
|
||
| if (reservationTime.isOccupied()) { | ||
| throw new BadRequestCustomException(ALREADY_OCCUPIED_RESERVATION_TIME); | ||
| } | ||
|
|
||
| reservationTime.reverseOccupied(); | ||
|
|
||
| Reservation reservation = Reservation.builder() | ||
| .status(COMPLETED) | ||
| .peopleCount(request.peopleCount()) | ||
| .shop(reservationTime.getShop()) | ||
| .reservationTime(reservationTime) | ||
| .build(); | ||
| return reservationRepository.save(reservation); | ||
| } |
There was a problem hiding this comment.
최종 예약 요구사항의 흐름대로, 전체적인 로직의 흐름은 잘 구성된 것 같습니다!!
Comment on lines
+38
to
+42
| public CreateReservationResponse registerReservation(CreateReservationRequest request) { | ||
| Reservation reservation = reservationService.validateReservationAndSaveIsEmpty(request); | ||
| return toCreateReservationResponse(reservation); | ||
| } | ||
|
|
There was a problem hiding this comment.
다만 저는 이 로직을 보면 facade와 service에 역할이 바뀐 것 같다는 느낌이 듭니다!!
더 나은 로직과 구조에 대해서 얘기를 나누어보면 좋을 것 같습니다!
hyun2371
approved these changes
Jan 1, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #32
⛏ 작업 상세 내용
📝 작업 요약
☑️ 중점적으로 리뷰 할 부분