feat : Owner 회원가입 & 로그인 구현 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dlswns2480
approved these changes
Jan 5, 2024
hyun2371
approved these changes
Jan 5, 2024
| public record JoinOwnerRequest( | ||
|
|
||
| String name, | ||
There was a problem hiding this comment.
message 옵션으로 검증 메세지를 추가해줘도 좋을 것 같아요!
|
|
||
| ALREADY_EXIST_OWNER("이미 존재하는 점주입니다"), | ||
| BAD_REQUEST_EMAIL_OR_PASSWORD("이메일 혹은 비밀번호를 확인해주세요"), | ||
| BAD_REQUEST_INPUT_GENDER_TYPE("성별 타입을 양식대로 입력해주세요"); | ||
|
|
There was a problem hiding this comment.
BadRequestCustomException으로 감싸주니까 INVALID_EMAIL_OR_PASSWORD 이렇게 네이밍해도 괜찮지 않을까 생각이 들었습니다!
| .filter(gender -> gender.isEqual(input)) | ||
| .findAny() | ||
| .orElseThrow(() -> new BadRequestCustomException(BAD_REQUEST_INPUT_GENDER_TYPE)); | ||
| } |
There was a problem hiding this comment.
request에서 검증하지 않고 Enum에서 input을 검증하면 캡슐화의 장점이 있는건지 궁금합니다!
There was a problem hiding this comment.
Enum으로의 변환로직? 이라고 생각할 때, request dto보다는 Enum 안에서 따로 로직이 있어야 된다고 생각하였습니다..!
| String email = "abc1234@gmail.com"; | ||
| String password = "qwer1234"; | ||
| String wrongPassword = "qwer12345"; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #17
⛏ 작업 상세 내용
📝 작업 요약
☑️ 중점적으로 리뷰 할 부분