Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Registry Support's k8s dependencies #1306

Closed
3 tasks done
Tracked by #1303
thepetk opened this issue Oct 25, 2023 · 3 comments · Fixed by devfile/registry-support#190
Closed
3 tasks done
Tracked by #1303

Update Registry Support's k8s dependencies #1306

thepetk opened this issue Oct 25, 2023 · 3 comments · Fixed by devfile/registry-support#190
Assignees
@michael-valdron
Labels
area/registry Devfile registry for stacks and infrastructure dependencies Pull requests that update a dependency file

Comments

@thepetk
Copy link
Contributor

thepetk commented Oct 25, 2023 •
edited by michael-valdron
Loading

Which area/kind this issue is related to?

/area registry

Issue Description

As part of #1303 we should check if we can update the dependency of k8s.io/apimachinery. This dependency is using the golang.org/x/net@v0.8.0 which should be updated to a newer version. Both server (direct) and generator (indirect) are using this module. For generator and registry-library that have apimachinery as indirect dependency we should update the direct dependencies that are using this package.

Acceptance Criteria

  • The direct dependency inside index/server should be updated.
  • Direct dependencies using k8s/apimachinery inside index/generator and registry-library should be updated.
  • Use the same versions that HAS uses
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Oct 25, 2023
@thepetk thepetk mentioned this issue Oct 25, 2023
Closed
9 tasks
@michael-valdron michael-valdron self-assigned this Oct 25, 2023
@michael-valdron michael-valdron changed the title Update Registry Suport k8s dependencies Update Registry Support k8s dependencies Oct 25, 2023
@michael-valdron
Copy link
Member

I can take this issue once its planned.

@michael-valdron michael-valdron changed the title Update Registry Support k8s dependencies Update Registry Support's k8s dependencies Oct 25, 2023
@rm3l rm3l added the dependencies Pull requests that update a dependency file label Oct 27, 2023
@michael-valdron michael-valdron mentioned this issue Nov 20, 2023
Merged
3 tasks
@michael-valdron
Copy link
Member

Updated all direct dependencies with tied indirect dependencies for patching k8s.io/apimachinery to v0.26.10.

Local dependency github.com/devfile/registry-support/index/generator now using local path:

# index server
replace github.com/devfile/registry-support/index/generator v0.0.0 => ../generator

# registry library
replace github.com/devfile/registry-support/index/generator v0.0.0 => ../index/generator

@michael-valdron
Copy link
Member

PR ready for review: devfile/registry-support#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-valdron michael-valdron

Labels
area/registry Devfile registry for stacks and infrastructure dependencies Pull requests that update a dependency file
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch k8s dependencies michael-valdron/devfile-registry-support
3 participants
@rm3l @thepetk @michael-valdron