Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library support for devfile schema - version 2.2.1 & version 2.2.2 #1454

Closed
1 task done
Tracked by #1476
thepetk opened this issue Feb 21, 2024 · 4 comments · Fixed by devfile/library#208
Closed
1 task done
Tracked by #1476
Assignees
Labels
area/library Common devfile library for interacting with devfiles

Comments

@thepetk
Copy link
Contributor

thepetk commented Feb 21, 2024

Which area/kind this issue is related to?

/area library

Issue Description

At the moment when the library parser tries to parse a devfile with schemaVersion=2.2.2 or schemaVersion=2.2.1 we get the error:

Error: failed to generate index struct: /build/stacks/dotnet60 devfile is not valid:
failed to populateAndParseDevfile: unable to find schema for version "2.2.2".
The parser supports devfile schema for version 2.0.0, 2.1.0, 2.2.0, v1alpha2

As seen in the pkg/devfile/parser/data/versions.go there is no reference for the 2.2.1 or the 2.2.2 versions.

Acceptance Criteria

  • Devfile library supports Devfile schema versions 2.2.1 & 2.2.2
@openshift-ci openshift-ci bot added the area/library Common devfile library for interacting with devfiles label Feb 21, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Feb 21, 2024

Steps to follow:

  1. Update the pkg/devfile/parser/data/versions.go to include 2.2.1 & 2.2.2
  2. Cut a pre-release for 2.2.3-alpha in the devfile/api.

cc @michael-valdron @yangcao77

@Jdubrick
Copy link
Contributor

Jdubrick commented Mar 14, 2024

Created PR to add support for 2.2.1 and 2.2.2 here: devfile/library#208

When we cut the pre-release for 2.2.3-alpha it is probably best to open another PR to library to have a 2.2.3 alpha version recognized. I noticed 2.2.1-alpha was being used prior. wdyt?

cc @michael-valdron @thepetk

@thepetk
Copy link
Contributor Author

thepetk commented Mar 18, 2024

Re-opening this as we might need to bump up the registry-support library's version so we can take advantage of the latest schemaVersion support. If you think it should be handled separately happy to open another issue

cc @Jdubrick

@thepetk thepetk reopened this Mar 18, 2024
@Jdubrick
Copy link
Contributor

Re-opening this as we might need to bump up the registry-support library's version so we can take advantage of the latest schemaVersion support. If you think it should be handled separately happy to open another issue

cc @Jdubrick

I think probably a good idea to open a new issue so we can keep the scope of both contained in their own issue. @thepetk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants