Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing schema versions 2.2.2 & 2.2.1 upon registry CI checks #1494

Closed
4 tasks done
thepetk opened this issue Mar 29, 2024 · 5 comments · Fixed by devfile/registry#356
Closed
4 tasks done
Assignees
Labels
area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure kind/epic A high level requirement that can/should be split into smaller issues

Comments

@thepetk
Copy link
Contributor

thepetk commented Mar 29, 2024

Which area this feature is related to?

/kind epic

Which area this bug is related to?

/area library
/area registry

Issue Descripton

The registry tests with odo3 are failing due to old library version

More detailed, the check_odov3 check is failing because odo is currently using an old version of the devfile/library which does not support atm the 2.2.1 and 2.2.2. In order to reproduce this behavior someone should Install odo version 3.15.0 and try to run odo dev using a devfile having schemaVersion=2.2.1.

In order to have more thorough testing for the registry stack updates our CI checks should allow testing those versions. Note that as a temporary fix the 2.2.1 & 2.2.2 versions have been excluded from the tests.

Acceptance Criteria

@Jdubrick
Copy link
Contributor

Jdubrick commented Apr 2, 2024

Once this is completed we will need to undo the patch here: devfile/registry#356

@thepetk
Copy link
Contributor Author

thepetk commented Apr 3, 2024

Re-opening as the PR merged was a temporary solution

@thepetk thepetk reopened this Apr 3, 2024
@thepetk thepetk changed the title Registry odo tests are failing for 2.2.1, 2.2.2 schema versions Support testing schema versions 2.2.2 & 2.2.1 upon registry CI checks Apr 9, 2024
@thepetk thepetk added kind/epic A high level requirement that can/should be split into smaller issues and removed kind/bug Something isn't working labels Apr 9, 2024
@thepetk thepetk self-assigned this Apr 9, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Apr 9, 2024

FYI after the temporary fix, I've transformed this issue into an EPIC

@thepetk thepetk removed their assignment Apr 9, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Apr 29, 2024

PR to update the odo library version is now merged

@thepetk
Copy link
Contributor Author

thepetk commented May 14, 2024

Closing as all items are completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles area/registry Devfile registry for stacks and infrastructure kind/epic A high level requirement that can/should be split into smaller issues
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants