-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for 2.2.1 and 2.2.2 schema versions #208
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 61.01% 61.11% +0.09%
==========================================
Files 43 43
Lines 5112 5117 +5
==========================================
+ Hits 3119 3127 +8
+ Misses 1804 1802 -2
+ Partials 189 188 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@michael-valdron i pushed a new commit for the changes. I took your advice about having the string pointer so if it needs an error it sets the string and if not it will be nil. I also had to make sure the schema versions were sorted so the output was in the correct order for error messages, im pretty sure this is due to the schemas being stored in a map so they're all out of order. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
A summary of changes made in this PR can be found below:
Which issue(s) this PR fixes:
fixes devfile/api#1454
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Unit/Functional tests
QE Integration test
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer:
Unit tests ran with
make test
should pass. Additionally when you try and parse a devfile on schema 2.2.1 or 2.2.2 now it should function and not spit an error message.