Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template and OWNERS #225

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Jdubrick
Copy link
Contributor

What does this PR do?:

  • Updates the PR template as part of devtools week
  • Updates OWNERS file

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick requested review from thepetk, michael-valdron and a team August 20, 2024 20:20
@openshift-ci openshift-ci bot requested a review from elsony August 20, 2024 20:20
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from consistency perspective, thinking that we've already migrated from OWNERS to CODEOWNERS for api & registry I'd say we might want to do the same across all repos in the future. WDYT?

Copy link

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor Author

/lgtm

from consistency perspective, thinking that we've already migrated from OWNERS to CODEOWNERS for api & registry I'd say we might want to do the same across all repos in the future. WDYT?

Yeah I think it would be good to open an issue to look into that. I support it!

@Jdubrick Jdubrick merged commit cd486bd into devfile:main Aug 21, 2024
5 checks passed
@michael-valdron
Copy link
Member

michael-valdron commented Aug 21, 2024

/lgtm
from consistency perspective, thinking that we've already migrated from OWNERS to CODEOWNERS for api & registry I'd say we might want to do the same across all repos in the future. WDYT?

Yeah I think it would be good to open an issue to look into that. I support it!

@thepetk @Jdubrick This might work for devfile/library as we only need OWNERS for OpenShift CI, other which use it though i.e. devfile/registry, devfile/registry-operator, and devfile/integration-tests all needed remain with OWNERS for the base directory for this reason.

@thepetk
Copy link
Contributor

thepetk commented Aug 21, 2024

/lgtm
from consistency perspective, thinking that we've already migrated from OWNERS to CODEOWNERS for api & registry I'd say we might want to do the same across all repos in the future. WDYT?

Yeah I think it would be good to open an issue to look into that. I support it!

@thepetk @Jdubrick This might work for devfile/library as we only need OWNERS for OpenShift CI, other which use it though i.e. devfile/registry, devfile/registry-operator, and devfile/integration-tests all needed remain with OWNERS for the base directory for this reason.

Yeah right, I had in mind that there was a reason that we've never implemented it in other repos but I've forgotten why. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants