Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions and improve ci logging #187

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Oct 19, 2023

Please specify the area for this PR

/area ci

What does does this PR do / why we need it:

This PR tries to fix the CI failure found here. The main points are:

  • Updates the github action of manusa/actions-setup-minikube and increases memory:
uses: manusa/actions-setup-minikube@3856c6fa039819f1c8e7e248b1fc5a8564e354c9 # v2.9.0
with:
  minikube version: 'v1.31.2'
  kubernetes version: 'v1.21.0'
  ...
  start args: '--addons=ingress --memory 4096 --cpus 2'
  • Updates the logging in case of conditions are not met in .ci/run_tests_minikube_linux.sh by printing the logs of every container of devfile-registry.

Which issue(s) this PR fixes:

Fixes devfile/api#1295

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

I've tried to reproduce and use this issue in my fork. The successful run is here: https://github.com/thepetk/devfile-registry-support/actions/runs/6576960168/job/17867518217?pr=5

* Update gh actions for nodejs16

Signed-off-by: thepetk <thepetk@gmail.com>

* Further updates on gh actions versions

Signe-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

@thepetk: The label(s) area/ci cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area ci

What does does this PR do / why we need it:

This PR tries to fix the CI failure found here. The main points are:

  • Updates the github action of manusa/actions-setup-minikube and increases memory:
uses: manusa/actions-setup-minikube@3856c6fa039819f1c8e7e248b1fc5a8564e354c9 # v2.9.0
with:
 minikube version: 'v1.31.2'
 kubernetes version: 'v1.28.1'
 ...
 start args: '--addons=ingress --memory 4096 --cpus 2'
  • Updates the logging in case of conditions are not met in .ci/run_tests_minikube_linux.sh by printing the logs of every container of devfile-registry.

Which issue(s) this PR fixes:

Fixes devfile/api#1295

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

I've tried to reproduce and use this issue in my fork. The successful run is here: https://github.com/thepetk/devfile-registry-support/actions/runs/6576960168/job/17867518217?pr=5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thepetk thepetk requested a review from kim-tsao October 19, 2023 16:04
@openshift-ci openshift-ci bot requested review from feloy and rm3l October 19, 2023 16:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@thepetk thepetk requested review from michael-valdron and removed request for feloy October 19, 2023 16:04
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a95cc88) 35.93% compared to head (468684c) 35.93%.

❗ Current head 468684c differs from pull request most recent head f816e33. Consider uploading reports for the commit f816e33 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   35.93%   35.93%           
=======================================
  Files           7        7           
  Lines        1347     1347           
=======================================
  Hits          484      484           
  Misses        816      816           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: thepetk <thepetk@gmail.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 086246b into devfile:main Oct 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devfile Registry deployment on minikube with helm keeps crash looping
2 participants