Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions and improve ci logging #187

Merged
merged 6 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .ci/run_tests_minikube_linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ helm install devfile-registry ./deploy/chart/devfile-registry --set global.ingre
# Wait for the registry to become ready
kubectl wait deploy/devfile-registry --for=condition=Available --timeout=600s
if [ $? -ne 0 ]; then
kubectl get pods
# Return the logs of the 3 containers in case the condition is not met
echo "devfile-registry container logs:"
kubectl logs -l app=devfile-registry --container devfile-registry
echo "oci-registry container logs:"
kubectl logs -l app=devfile-registry --container oci-registry
echo "registry-viewer container logs:"
kubectl logs -l app=devfile-registry --container registry-viewer
# Return the description of every pod
kubectl describe pods
exit 1
fi
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ jobs:
with:
go-version: 1.18
- name: Setup Minikube
uses: manusa/actions-setup-minikube@v2.7.1
uses: manusa/actions-setup-minikube@3856c6fa039819f1c8e7e248b1fc5a8564e354c9 # v2.9.0
with:
minikube version: 'v1.21.0'
kubernetes version: 'v1.21.0'
minikube version: 'v1.31.2'
kubernetes version: 'v1.28.1'
thepetk marked this conversation as resolved.
Show resolved Hide resolved
driver: 'docker'
github token: ${{ secrets.GITHUB_TOKEN }}
start args: '--addons=ingress'
start args: '--addons=ingress --memory 4096 --cpus 2'
- name: Run the devfile registry integration tests
run: |
export GOPATH=$(go env GOPATH)
Expand Down
Loading