-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add only default tags in indexComponent #193
Conversation
@thepetk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 35.58% 35.58%
=======================================
Files 7 7
Lines 1360 1360
=======================================
Hits 484 484
Misses 829 829
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/area registry
What does does this PR do / why we need it:
The PR updates the
index
tags generation process. More specifically it only adds thedefault
version tags into eachindexComponent
instead of adding all the tags from all versions.This update fixes the issue of having
Deprecated
stack version. For example, if one version of a stack is deprecated (so it has the Deprecated tag) then in thev2index/all
endpoint we will have theDeprecated
tag representing all versions.Which issue(s) this PR fixes:
Fixes devfile/api#1289
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: