Fix error related to directory does not exist #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
Bug fix
What does does this PR do / why we need it:
This PR adds a check to make sure that before performing a
cd
command we verify that$stackDir
is a directory and not a file. Previous to this check it was attempting to performcd OWNERS
whereOWNERS
is a file, subsequently throwing an error/warning during the build process.Which issue(s) this PR fixes:
fixes devfile/api#1207
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
While trying to test the changes for this fix I was running into issues with running the
build.sh
script locally. I opened a spike issue to investigate if anything can be changed for this. devfile/api#1447