Updated CodeQL GitHub Action to v3 #1623 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Horiodino <holiodin@gmail.com>
Horiodino
force-pushed
the
Update_CodeQL_Action_to_version_v3
branch
from
0e66f9b
to
9d07ee0
Compare
thepetk
requested changes
Sep 29, 2024
thepetk
requested changes
Sep 30, 2024
.github/workflows/ci.yaml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| fi | |||
|
|
|||
| - name: Upload SARIF file | |||
| uses: github/codeql-action/upload-sarif@v2 | |||
| uses: github/codeql-action/upload-sarif@v3@461ef6c76dfe95d5c364de2f431ddbd31a417628 | |||
There was a problem hiding this comment.
Suggested change
| uses: github/codeql-action/upload-sarif@v3@461ef6c76dfe95d5c364de2f431ddbd31a417628 | |
| uses: github/codeql-action/upload-sarif@461ef6c76dfe95d5c364de2f431ddbd31a417628 # v3.26.9 |
Horiodino
force-pushed
the
Update_CodeQL_Action_to_version_v3
branch
from
ccaf4df
to
7bf469e
Compare
Horiodino
force-pushed
the
Update_CodeQL_Action_to_version_v3
branch
from
7bf469e
to
040adfb
Compare
thepetk
requested changes
Sep 30, 2024
.github/workflows/ci.yaml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| fi | |||
|
|
|||
| - name: Upload SARIF file | |||
| uses: github/codeql-action/upload-sarif@v2 | |||
| uses: github/codeql-action/upload-sarif@v3.26.9@461ef6c76dfe95d5c364de2f431ddbd31a417628 | |||
There was a problem hiding this comment.
Suggested change
| uses: github/codeql-action/upload-sarif@v3.26.9@461ef6c76dfe95d5c364de2f431ddbd31a417628 | |
| uses: github/codeql-action/upload-sarif@461ef6c76dfe95d5c364de2f431ddbd31a417628 # v3.26.9 |
For consistency reasons I'd prefer if we could keep the same format for this update.
Horiodino
force-pushed
the
Update_CodeQL_Action_to_version_v3
branch
2 times, most recently
from
242f3dd
to
570f4f5
Compare
thepetk
requested changes
Sep 30, 2024
.github/workflows/ci.yaml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| fi | |||
|
|
|||
| - name: Upload SARIF file | |||
| uses: github/codeql-action/upload-sarif@v2 | |||
| uses: github/codeql-action/upload-sarif@461ef6c76dfe95d5c364de2f431ddbd31a417628 | |||
There was a problem hiding this comment.
I'd prefer adding as a comment the version at the end so it's more readable.
Suggested change
| uses: github/codeql-action/upload-sarif@461ef6c76dfe95d5c364de2f431ddbd31a417628 | |
| uses: github/codeql-action/upload-sarif@461ef6c76dfe95d5c364de2f431ddbd31a417628 # v3.26.9 |
Signed-off-by: Horiodino <holiodin@gmail.com>
Horiodino
force-pushed
the
Update_CodeQL_Action_to_version_v3
branch
from
570f4f5
to
64d7114
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Horiodino, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Horiodino I've merged your updates! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Summarize the changes you made as part of this pull request.
Updated CodeQL GitHub Action to version v3
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
devfile/api#1623
Acceptance Criteria
Tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.