-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new devfile version with an https endpoint #342
Conversation
Hi @vinokurig. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the prior chores to update .net to https I think my vote is that we should update |
@vinokurig apologies our discussion here might be misleading. I think it would be nice to patch the
This way we only have the |
Done, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig I've only added a minor suggestion
@thepetk Looks like all comments are addressed, could you please take a look? |
@vinokurig I think only the DCO check needs to be fixed. Overall looks good to me. /ok-to-test |
Signed-off-by: ivinokur <ivinokur@redhat.com>
@vinokurig minor suggestion is to remove the |
Signed-off-by: ivinokur <ivinokur@redhat.com>
Done. |
Signed-off-by: ivinokur <ivinokur@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thepetk, vinokurig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thepetk I don't have merge permissions, could you merge please? |
What does this PR do?:
Add an https endpoint to be able to run the application on Eclipse CHE
Which issue(s) this PR fixes:
eclipse-che/che#22869
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: