Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEMP ignore schemaVersions 2.2.2 and 2.2.1 due to odo incompatibility #356

Merged
merged 1 commit into from
Apr 3, 2024
Merged

TEMP ignore schemaVersions 2.2.2 and 2.2.1 due to odo incompatibility #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/odov3/odo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,13 @@ func TestOdo(t *testing.T) {
devfile, _, err := devfile.ParseDevfileAndValidate(parserArgs)
g.Expect(err).To(BeNil())

schemaVersion := devfile.Data.GetSchemaVersion()
name := devfile.Data.GetMetadata().Name
version := devfile.Data.GetMetadata().Version
starterProjects, err := devfile.Data.GetStarterProjects(common.DevfileOptions{})
g.Expect(err).To(BeNil())

stack := Stack{name: name, version: version, path: path, starterProjects: starterProjects, base: base}
stack := Stack{name: name, schemaVersion: schemaVersion, version: version, path: path, starterProjects: starterProjects, base: base}

stacks = append(stacks, stack)
}
Expand Down Expand Up @@ -152,6 +153,12 @@ var _ = Describe("test starter projects from devfile stacks", func() {
for _, stack := range stacks {
stack := stack

// TEMP: ignore testing schema versions 2.2.2 & 2.2.1 due to odo incompatibility
// related issue: https://github.com/devfile/api/issues/1494
if stack.schemaVersion == "2.2.1" || stack.schemaVersion == "2.2.2" {
continue
}

if len(stack.starterProjects) == 0 {
It(fmt.Sprintf("stack: %s version: %s no_starter", stack.name, stack.version), func() {
// No starter projects defined in Devfile => let's start a Dev Session with --no-commands
Expand Down
1 change: 1 addition & 0 deletions tests/odov3/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ type ForwardedPort struct {
type Stack struct {
name string
version string
schemaVersion string
path string
base string
starterProjects []v1alpha2.StarterProject
Expand Down
Loading