Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock.Protected().Setup<int>("Foo") fails base implementation of Foo is hidden in the derived class #1342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VladimirKhvostov
Copy link

This PR fixes an issue described in the #1341

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kzu
Copy link
Member

kzu commented Aug 4, 2023

Thanks for the PR! Could you rebase on top of main, since files moved around?

Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed & tested this in detail TBH, but it generally looks good to me.

The changelog should be first updated with the latest few missing releases though, otherwise the changelog entry will end up with an incorrect (already published) version.

CHANGELOG.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants