Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of It.Is matcher when used with an expression by compiling only once #1512

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

peterder72
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@peterder72
Copy link
Contributor Author

Forgot to update the changelog, will do

@kzu
Copy link
Member

kzu commented Sep 6, 2024

No need. The changelog is generated from the PRs/Issues associated once merged, at the time of release.

@kzu kzu changed the title Made It.Is match expression compilation only happen once Improve performance of It.Is matcher when used with an expression by compiling only once Sep 10, 2024
@kzu
Copy link
Member

kzu commented Sep 10, 2024

You can just remove the commit to the changelog and then I'll merge it.

@peterder72
Copy link
Contributor Author

peterder72 commented Sep 10, 2024

Done! It would also be a good idea to update the Contributing.md manual, seeing that the procedure is different now. But in a separate PR

@kzu
Copy link
Member

kzu commented Sep 10, 2024

I think you actually need to rebase on top of main and just skip the commit to the changelog:

image

@peterder72
Copy link
Contributor Author

Rebased, fixed now

@kzu kzu enabled auto-merge (rebase) September 17, 2024 00:37
@kzu kzu merged commit a481e8d into devlooped:main Sep 17, 2024
4 checks passed
@devlooped devlooped locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants