Added update script from 1.1.1 to 1.3.0 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertdb
requested changes
May 5, 2022
update.ps1
Outdated
| else # All update preconditions passed | ||
| { | ||
| # Create backup of dockerd | ||
| Copy-Item "$script:windowsBinariesPath\dockerd.exe" "C:\" -Recurse -Force |
There was a problem hiding this comment.
Better create a temporary file (https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/new-temporaryfile?view=powershell-7.2) and copy the file there.
Please apply also that change to installation to avoid writing directly on C: when decompressing dockerd
update.ps1
Outdated
Comment on lines
69
to
73
| # Restore and remove backup of dockerd | ||
| Stop-Service -Name "docker" | ||
| Copy-Item "C:\dockerd.exe" $script:windowsBinariesPath -Recurse -Force | ||
| Remove-Item "C:\dockerd.exe" | ||
| Start-Service -Name "docker" |
There was a problem hiding this comment.
BTW, this and the above assume that the user installed Windows containers support.
albertdb
requested changes
May 9, 2022
Co-authored-by: albertdb <albertdb@users.noreply.github.com>
Co-authored-by: albertdb <albertdb@users.noreply.github.com>
Co-authored-by: albertdb <albertdb@users.noreply.github.com>
Co-authored-by: albertdb <albertdb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.