Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#138: added updater for mvn 4.x versions #172

Conversation

MattesMrzik
Copy link
Contributor

Fixes #138. Maven updates for the 4.x releases are distributed via a different URL than the other releases, so this updater has been added to retrieve the 4.x releases from the new website. This may only be necessary temporarily, as these 4.x versions will later be listed on the original URL as well.

@coveralls
Copy link
Collaborator

coveralls commented Jan 8, 2024

Pull Request Test Coverage Report for Build 8758264712

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 59.772%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/url/updater/UpdateManager.java 6 0.0%
Totals Coverage Status
Change from base Build 8757518371: -0.04%
Covered Lines: 4587
Relevant Lines: 7389

💛 - Coveralls

Copy link
Contributor

@aBega2000 aBega2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the one question I have asked, everything else seems fine and correct

@tobka777 tobka777 assigned hohwille and unassigned aBega2000 Jan 11, 2024
@hohwille
Copy link
Member

Note: Great work, looks all good, but we need to have devonfw/ide#1374 out in the wild as otherwise we are causing more harm than good.
So my suggestion would be to release the PR with devonfw-ide this month and then still wait ~1 month for it to spread out before we merge this PR and populate the maven 4.x-alpha versions.

@hohwille
Copy link
Member

So my suggestion would be to release the PR with devonfw-ide this month and then still wait ~1 month for it to spread out before we merge this PR and populate the maven 4.x-alpha versions.

3 month later should be safe for merge.
If people are using outdated versions of devonfw-ide and therefore get maven updated to 4.*-alpha they need to run devon ide update scripts to prevent this undesired behavior.

@hohwille hohwille merged commit cc69fdf into devonfw:main Apr 19, 2024
3 checks passed
@hohwille hohwille added this to the urls milestone Apr 19, 2024
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story-review marks PRs that will be presented in the sprint-review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

maven 4.x releases not available in ide-urls
4 participants