#525 Added online state check before downloading #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11120017041Details
💛 - Coveralls |
hohwille
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
@WorkingAmeise thanks for your PR. You found the relevant spots in the code where to implement this feature. Also throwing CliOfflineException is the perfect solution. 👍
You PR is functionally correct. I just left some comments for further thoughts and improvements. Please have a look.
cli/src/main/java/com/devonfw/tools/ide/repo/AbstractToolRepository.java
Outdated
Show resolved
Hide resolved
|
Can you please also check DoD: CHANGELOG entry needs to be added. |
…-disable-downloads-when-called-with-offline
…-disable-downloads-when-called-with-offline
…-disable-downloads-when-called-with-offline
…-disable-downloads-when-called-with-offline
…-disable-downloads-when-called-with-offline
hohwille
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@WorkingAmeise thanks for your PR and your rework.
You addressed my review comment well and solved the centralization of messages in CliOfflineException perfectly. 👍
Please remove CHANGELOG.adoc.orig as commented and we can merge this PR.
WorkingAmeise
deleted the
bug/525-disable-downloads-when-called-with-offline
branch
hohwille
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #525
now Throws a CliOfflineException if the offline flag is set