Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#627: Fix info-log message that breaks processable context output #649

Merged
merged 5 commits into from
Oct 1, 2024
Merged

#627: Fix info-log message that breaks processable context output #649

merged 5 commits into from
Oct 1, 2024

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Sep 24, 2024 •
edited
Loading

Fixes: #627

This PR changes info.log to interaction.log message output to prevent an bug that causes the message to be interpreted as a command by bash

@coveralls
Copy link
Collaborator

coveralls commented Sep 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11049396737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.107%
Totals Coverage Status
Change from base Build 11020021104: 0.0%
Covered Lines: 6105
Relevant Lines: 8890
💛 - Coveralls

@alfeilex alfeilex marked this pull request as ready for review September 24, 2024 08:51
jan-vcapgemini
jan-vcapgemini approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hohwille
hohwille approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge.

@hohwille hohwille merged commit dba2696 into devonfw:main Oct 1, 2024
4 checks passed
@hohwille hohwille added this to the release:2024.09.002 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
None yet
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.09.002
Development

Successfully merging this pull request may close these issues.

Still log messages break processable command output
4 participants
@alfeilex @coveralls @hohwille @jan-vcapgemini