Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#657: fix installation of java 8 #658

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

hohwille
Copy link
Member

fixes #657

  • improved VersionIdentifierTest and also make the problem transparent
  • removed version validator to fix the actual bug Cannot install Java 8 #657

@hohwille hohwille self-assigned this Sep 27, 2024
@hohwille hohwille added bugfix java related to Java code, the Java Virtual Machine and directly related tooling (OpenJDK, Adoptium) install installation process of IDE + tools and install commandlet labels Sep 27, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11103685641

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 66.142%

Totals Coverage Status
Change from base Build 11074150869: 0.03%
Covered Lines: 6083
Relevant Lines: 8851

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ready to merge. Will we reactivate it later? if yes, we need to add a new issue with the removed code part.

@hohwille
Copy link
Member Author

Will we reactivate it later?

This is not planned since it seems we need to support versions that have unclear lifecycle phases or are otherwise not what we consider valid. The question is rather if we can remove the isValid() method at all since it is not practically used.

@hohwille hohwille merged commit 92c5425 into devonfw:main Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix install installation process of IDE + tools and install commandlet java related to Java code, the Java Virtual Machine and directly related tooling (OpenJDK, Adoptium)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Cannot install Java 8
3 participants