-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#663: eclipse force loop #665
Merged
hohwille
merged 8 commits into
devonfw:main
from
hohwille:feature/663-eclipse-force-loop
Sep 30, 2024
Merged
#663: eclipse force loop #665
hohwille
merged 8 commits into
devonfw:main
from
hohwille:feature/663-eclipse-force-loop
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-vcapgemini
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've added some questions.
cli/src/test/resources/ide-projects/eclipse/eclipseproject/home/.ide/ide.properties
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 11113626165Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #663
TomcatTest
that was fragile and broke - it is now more realisticSide-note: Before
ToolRepositoryMock.resolveVersion
was a pointless mock causing unrealistic behaviour. I fixed this but kept a legacy fallback avoiding to cleanup most other tests. We will get an error logged and can cleanup existing tests that test with inconsistent config.