Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#659: #664: fix deps #667

Merged
merged 10 commits into from
Oct 1, 2024
Merged

#659: #664: fix deps #667

merged 10 commits into from
Oct 1, 2024

Conversation

hohwille
Copy link
Member

fixes #659
fixes #664

@hohwille hohwille added tomcat bugfix dependency Tool dependencies (if tool A requires tool B) labels Sep 30, 2024
@hohwille hohwille self-assigned this Sep 30, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 30, 2024
@hohwille
Copy link
Member Author

hohwille commented Sep 30, 2024 •
edited
Loading

Build failed with still somehow unstable or fragile IntellijTest:

[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.518 s <<< FAILURE! -- in com.devonfw.tools.ide.tool.intellij.IntellijTest
[ERROR] com.devonfw.tools.ide.tool.intellij.IntellijTest.testIntellijRun(String, WireMockRuntimeInfo)[3] -- Time elapsed: 0.029 s <<< FAILURE!
java.lang.AssertionError: 

Expecting path:
  /home/runner/work/IDEasy/IDEasy/cli/target/test-projects/intellij/project/software/intellij/bin/intellijtest
to exist (symbolic links were followed).
	at com.devonfw.tools.ide.tool.intellij.IntellijTest.testIntellijRun(IntellijTest.java:136)

In the plain maven logs of surefire it is really hard to trace down errors that do not occur locally (on Windows).
What test value is [3]? Is that linux since it is the last value in the array?

Update: Created #669

@coveralls
Copy link
Collaborator

coveralls commented Sep 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11122792269

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 66.525%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/tomcat/Tomcat.java 5 75.38%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 16 85.92%
Totals Coverage Status
Change from base Build 11122783103: 0.0%
Covered Lines: 6123
Relevant Lines: 8860
💛 - Coveralls

@hohwille hohwille mentioned this pull request Sep 30, 2024
Open
jan-vcapgemini
jan-vcapgemini approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added some questions.

cli/src/main/java/com/devonfw/tools/ide/tool/tomcat/Tomcat.java Outdated Show resolved Hide resolved
cli/src/test/java/com/devonfw/tools/ide/tool/intellij/IntellijTest.java Show resolved Hide resolved
.../test/resources/ide-projects/intellij/repository/intellij/intellij/default/linux/bin/idea.sh Show resolved Hide resolved
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/tool/tomcat/Tomcat.java
b4484c4 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille hohwille merged commit 4464475 into devonfw:main Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
bugfix dependency Tool dependencies (if tool A requires tool B) tomcat
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.09.002
Development

Successfully merging this pull request may close these issues.

Tool dependencies and environment variables still not working properly Tomcat not working on Windows
3 participants
@hohwille @coveralls @jan-vcapgemini