Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#669: Attempt to fix background script tests #671

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

jan-vcapgemini
Copy link
Contributor

Fixes: #669

Implements:

  • moved checkInstallation before run test validation

@coveralls
Copy link
Collaborator

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11128283373

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.509%

Totals Coverage Status
Change from base Build 11128087566: 0.0%
Covered Lines: 6126
Relevant Lines: 8868

💛 - Coveralls

@jan-vcapgemini jan-vcapgemini changed the title #669: Attempt to fix background script #669: Attempt to fix background script tests Oct 1, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for the PR. Surely a quickfix of #669 👍
IMHO not a long term solution but will surely reduce the probability / likelihood that the test fails due to async effects.

Happy to merge asap.

@hohwille hohwille added this to the release:2024.09.002 milestone Oct 1, 2024
@hohwille hohwille merged commit b0a202b into devonfw:main Oct 1, 2024
4 checks passed
@jan-vcapgemini jan-vcapgemini deleted the fix/669-idea-background-tests branch November 4, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Make JUnit Tests reliable again
3 participants