-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#737: Added cd command to shell commandlet #748
base: main
Are you sure you want to change the base?
#737: Added cd command to shell commandlet #748
Conversation
Added the command cd to the shell commandlet that allows the user to switch the directory inside the ide shell
Pull Request Test Coverage Report for Build 11921396317Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the cd command to our Shell. I've added some CRs, please resolve.
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java
Outdated
Show resolved
Hide resolved
private int changeDirectory(CliArguments cliArgs) { | ||
if (!cliArgs.hasNext()) { | ||
this.context.error("Error: 'cd' requires a directory argument."); | ||
return -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the error code.
…dlet.java Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
…dlet.java Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
added current working directory path to prompt name improved existing directory check adjusted exit codes
removed whitespace from ide prompt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Ready for review.
Fixes: #737
Implements: