Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the Imports and Exports #26

Open
KevinStarWars opened this issue Sep 18, 2019 · 0 comments
Open

Restructure the Imports and Exports #26

KevinStarWars opened this issue Sep 18, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@KevinStarWars
Copy link
Contributor

Angular’s best practices (https://angular.io/guide/styleguide) show that transitive imports should be used through a CoreModule. The CoreModule is supposed to be imported once into the AppModule. A CoreModule makes the import and export statements much more readable and also leads to a higher maintainability of the code.
All material modules should be placed inside a dedicated MaterialModule, which is then imported into the CoreModule.
Unused export statements should also be removed, since they do not provide any value.
Tasks, which derive from this issue:

  • create a CoreModule inside a core folder below the src folder.
  • restructure the imports so that multiple imports are avoided and the imports are clear.
  • restructure the exports so that unused exports do not exist.
@KevinStarWars KevinStarWars added the enhancement New feature or request label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant