Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1369: added latest stable version pattern #1374

Conversation

MattesMrzik
Copy link
Contributor

@MattesMrzik MattesMrzik commented Jan 3, 2024

Closes #1369. To select the latest version (even unstable), one can pass *! or something like 1.2*!

to select a latest stable version one can pass *! or something like 1.2*!
@github-actions github-actions bot added bash related to bash shell or scripts scripts related to shell scripts (bash and CMD) labels Jan 3, 2024
@github-actions github-actions bot added the documentation related to documentation (AsciiDoc) label Jan 3, 2024
@CREITZ25 CREITZ25 assigned MattesMrzik and unassigned CREITZ25 Jan 5, 2024
@hohwille hohwille added this to the release:2024.01.001 milestone Jan 5, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattesMrzik thanks for this great PR. You also cleanup the code removing lots of typos and trailing spaces. Your implementation to get the latest stable version also looks solid and has nice documentation.
As already commented, you are using a tool that is not available on MacOS so you need to adapt that part and find a different solution.
Further you missed a small but important detail from the story demand:
You need to invert the invocations of the functions getLatestSoftwareVersion and getLatestStableSoftwareVersion.
See from IDEasy:

  /** {@link VersionIdentifier} "*" that will resolve to the latest stable version. */
  public static final VersionIdentifier LATEST = VersionIdentifier.of("*");

If the version is undefined we also want to install the latest stable version, what is the main purpose of the story as devonfw-ide users got unstable versions installed by default if those are the latest ones available.

@hohwille
Copy link
Member

hohwille commented Jan 6, 2024

setup test failed with:

******** ATTENTION ********
Could not resolve version prefix 17* : no matching version found in /home/runner/work/ide/ide/scripts/target/integration-test/test-setup/urls/java/java/
We are sorry for the inconvenience. Please check the above errors, resolve them and try again.
Command 'java setup silent' failed with exit code 255

the line that determined the edition in doGetLatestSoftwareVersion was missing
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattesMrzik thanks for your fix. Now complete and ready for merge. Good job 👍

@hohwille hohwille merged commit d6588e1 into devonfw:master Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Ability to select latest stable version via version pattern.
3 participants