Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile added #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

profile added #13

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0b3050
profile added
suvmanda Oct 7, 2020
c49e3bd
PR Comments Added
suvmanda Oct 7, 2020
f6717ae
PR comment fixed
suvmanda Oct 7, 2020
a80dfb7
PR Comments fixed
suvmanda Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 45 additions & 36 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@
<version>${maven.resources.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven.compiler.plugin.version}</version>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven.compiler.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down Expand Up @@ -131,7 +131,7 @@
<version>${maven.javadoc.plugin.version}</version>
<configuration>
<!-- http://jira.codehaus.org/browse/MJAVADOC-308 -->
<!--<maxmemory>5048m</maxmemory>-->
<!--<maxmemory>5048m</maxmemory> -->
<notree>true</notree>
<show>protected</show>
<encoding>${project.reporting.outputEncoding}</encoding>
Expand Down Expand Up @@ -222,7 +222,8 @@
<useMissingFile>true</useMissingFile>
<failOnMissing>true</failOnMissing>
<licenseMerges>
<licenseMerge>Apache Software License, Version 2.0|The Apache Software License, Version 2.0|Apache 2.0|Apache License, Version 2.0</licenseMerge>
<licenseMerge>Apache Software License, Version 2.0|The Apache Software License, Version 2.0|Apache
2.0|Apache License, Version 2.0</licenseMerge>
</licenseMerges>
</configuration>
</plugin>
Expand Down Expand Up @@ -270,14 +271,14 @@
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<encoding>${project.build.sourceEncoding}</encoding>
<source>${java.version}</source>
<target>${java.version}</target>
<fork>true</fork>
</configuration>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<encoding>${project.build.sourceEncoding}</encoding>
<source>${java.version}</source>
<target>${java.version}</target>
<fork>true</fork>
</configuration>
</plugin>

<plugin>
Expand Down Expand Up @@ -343,25 +344,6 @@
</configuration>
</plugin>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that tags on the second level should have one line between them, tags on every other level should not. So if you coud add one empty line between 345-346 that would be great

<!-- JaCoCo for test coverage -->
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>default-prepare-agent</id>
<goals>
<goal>prepare-agent</goal>
</goals>
</execution>
<execution>
<id>default-report</id>
<goals>
<goal>report</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
Expand Down Expand Up @@ -437,10 +419,36 @@
</reportSet>
</reportSets>
</plugin>
</plugins>
</plugins>
</reporting>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comment above, one empty line here between </reporting> and <profiles> would be perfect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmarniazman . All comments are fixed.

<profiles>
<!-- JaCoCo for test coverage -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hohwille Was this how you meant to include the jacoco-report profile into maven-parent? I thought this was a good way of doing it. After this PR is merged, we can also delete the profile from the pom.xml of sonar-devon4j-plugin.

<profile>
<id>jacoco-report</id>
<build>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>default-prepare-agent</id>
<goals>
<goal>prepare-agent</goal>
</goals>
</execution>
<execution>
<id>default-report</id>
<goals>
<goal>report</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>deploy</id>
<build>
Expand Down Expand Up @@ -555,8 +563,8 @@
<releases>
<enabled>false</enabled>
</releases>
</repository>
</repositories>
</repository>
</repositories>
</profile>
</profiles>

Expand All @@ -565,7 +573,8 @@
<url>https://github.com/${github.organization}/${github.repository}/issues</url>
</issueManagement>

<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false">
<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false"
child.scm.url.inherit.append.path="false">
<connection>scm:git:https://github.com/${github.organization}/${github.repository}.git</connection>
<developerConnection>scm:git:https://github.com/${github.organization}/${github.repository}.git</developerConnection>
<url>https://github.com/${github.organization}/${github.repository}/tree/${github.default.branch}</url>
Expand Down