-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documention on Integration Tests is missing and add them to CI #24
Comments
Yes, I have test instance on my PC in docker with 30days free licence |
It would be great :) |
Hi @allburov
|
@zhan9san I think it's not. The best way - create a docker container during integration tests or use SaaS solution and run tests there. If you want to - you can create separate tests with mocks but let's keep the original integration tests for real integration tests.
|
I agree with you. Regarding container, I didn't find an out-of-box solution. At least, there are two manual steps.
We cannot do anything during integration tests workflow until there is an out-of-box container. BTW, have you tried to reach out to Jfrog getting a sponsored SaaS installation? |
I haven't. We've talked about this with one of contributors, but didn't make any steps further.
It's probably was the reason why we didn't add integration tests yet |
@allburov |
@beliaev-maksim does it support API calls? "Free" plan didn't support API before |
I imagine that the free cloud version supports the same APIs as the OSS version (which is missing a lot of basic stuff). I am dealing with the same issues trying to run integration tests with my project (which depends on this project!), so I'll be watching this issue as well: My project is a little easier since most of what it actually does, does not require a pro license (there's a piece that does that I'm working to remove), but the pro APIs would be most useful in trying to set up the CI environment and that's where I'm hitting issues myself. If there's any luck getting a sponsored open source license for this purpose I'd love to hear how that conversation went! |
The integration tests aren't run on the Travis CI, @allburov do you run them against your own Artifactory Instance?
I know that the API isn't available without an Artifactory license, I've just sent them a support request asking if they could also add API scope to the free Artifactory version, otherwise I don't think it will be possible to run integration tests against via. Travis.
Seems go-artifactory is getting an Artifactory Cloud instance sponsored for their CI tests.
The text was updated successfully, but these errors were encountered: