Out of tree classes need to re-implement _get_all if baseurl != /artifactory

[rupaschomaker]

ProjectUser and some other objects require /artifactory to be stripped from drive.

The current base _get_all() method referred to below:

artifactory/artifactory.py

Line 2090 in a95d10e

if cls is Project:

has explicit knowledge about which classes should have /artifactory stripped. Putting this knowledge in the base class doesn't seem right since it can't know the proper behavior of all sub-classes.

Alternatively, maybe check a properly that is set by the implementor that triggers behavior. (eg: self.baseurl)

Using an optional argument to _get_all() won't work because in the lazy=True case, .read() doesn't know whether /artifactory should be stripped (again unless it is overridden).

Thoughts?

[beliaev-maksim]

@rupaschomaker
would you like to propose a PR to initiate a discussion?

[beliaev-maksim]

can you share a code snippet that causes issues?