Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "FEDERATED" repository types #398

Open
RoeeDr opened this issue Nov 30, 2022 · 2 comments
Open

Support "FEDERATED" repository types #398

RoeeDr opened this issue Nov 30, 2022 · 2 comments
Labels
enhancement Feature request to extend functionality Help Wanted We will be glad if somebody proposes a solution via PR

Comments

@RoeeDr
Copy link
Contributor

RoeeDr commented Nov 30, 2022

Currently, calling get_repositories on artifactory that contains federated repositories will crash:

Traceback (most recent call last):
  File "/venv/lib/python3.9/site-packages/artifactory.py", line 2137, in get_repositories
    return self._get_all(
  File "/venv/lib/python3.9/site-packages/artifactory.py", line 2109, in _get_all
    item.read()
AttributeError: 'NoneType' object has no attribute 'read'

This happens since create_by_type doesn't support the federated type and just returns None.

I can also open a PR on it myself, since the federated type should mostly be handled like a local repository if I understand correctly from the docs:
https://www.jfrog.com/confluence/display/JFROG/Federated+Repositories

@beliaev-maksim
Copy link
Member

looks like it is similar to local + additional features

I think we need to create a new type and for the moment just inherit the functionality of local one.

please submit a PR with proposal

@beliaev-maksim beliaev-maksim added Help Wanted We will be glad if somebody proposes a solution via PR enhancement Feature request to extend functionality labels Nov 30, 2022
@RoeeDr
Copy link
Contributor Author

RoeeDr commented Dec 3, 2022

@beliaev-maksim do you have any estimate on when can you review the PR? No rush on anything, just want to get an estimate on the fix on my end (tested the code on real federated repos btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request to extend functionality Help Wanted We will be glad if somebody proposes a solution via PR
Development

No branches or pull requests

2 participants