fix: prevented chart updation when its in use #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik-579
requested changes
Aug 11, 2023
kartik-579
requested changes
Aug 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
kartik-579
approved these changes
Aug 14, 2023
nishant-d
reviewed
Aug 22, 2023
| @@ -213,7 +213,12 @@ func (handler *ChartRepositoryRestHandlerImpl) UpdateChartRepo(w http.ResponseWr | |||
| common.WriteJsonResp(w, err, nil, http.StatusBadRequest) | |||
| return | |||
| } | |||
|
|
|||
| err = handler.chartRepositoryService.ValidateDeploymentCount(request) | |||
There was a problem hiding this comment.
we can put this validation after RBAC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chart repo which is used to deploy helm app can be updated through postman, which should not happen.
Fixes #3455
How Has This Been Tested?
Checklist: