Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image broken in default slack notification template #5829

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

SATYAsasini
Copy link
Contributor

@SATYAsasini SATYAsasini commented Sep 11, 2024

Description

Fixes #5607

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Sep 23, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Ash-exp Ash-exp changed the base branch from main to develop September 23, 2024 13:52
@Ash-exp Ash-exp self-assigned this Sep 23, 2024
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
97.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit fce48ae into develop Sep 24, 2024
4 of 5 checks passed
@Ash-exp Ash-exp deleted the def-notifier-template branch September 24, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Slack Notification missing image
3 participants