Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactoring ci pipeline reader service #6062

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Nov 8, 2024

Description

This PR adds reader service for ci_pipeline repository.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1112

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Ash-exp Ash-exp self-assigned this Nov 8, 2024
@Ash-exp Ash-exp added the be-refactoring-read-bean Backend Refactoring Reader Services label Nov 8, 2024
@Ash-exp Ash-exp changed the title Chore refactoring ci pipeline chore: refactoring ci pipeline reader service Nov 8, 2024
nishant-d
nishant-d previously approved these changes Nov 14, 2024
kartik-579
kartik-579 previously approved these changes Nov 15, 2024
Copy link

gitguardian bot commented Nov 15, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
463396 Triggered Generic Password 3b701f7 pkg/chartRepo/ChartRepositoryService.go View secret
463396 Triggered Generic Password 3b701f7 pkg/chartRepo/ChartRepositoryService.go View secret
14517591 Triggered Generic Password 3b701f7 pkg/chartRepo/ChartRepositoryService_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarcloud bot commented Nov 15, 2024

@Ash-exp Ash-exp merged commit 2895460 into develop Nov 15, 2024
4 checks passed
@Ash-exp Ash-exp deleted the chore-refactoring-ci-pipeline branch November 15, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
be-refactoring-read-bean Backend Refactoring Reader Services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants