fix: html best practice

dewanakl · Dec 28, 2024 · f3fac51 · f3fac51
1 parent 1cdbebb
commit f3fac51
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/js/card.js b/js/card.js
@@ -58,11 +58,9 @@ export const card = (() => {
 
     const renderLike = (comment) => {
         return `
-        <button style="font-size: 0.8rem;" onclick="like.like(this)" data-uuid="${comment.uuid}" class="btn btn-sm btn-outline-${theme.isDarkMode('light', 'dark')} ms-auto rounded-3 p-0" data-offline-disabled>
-            <div class="d-flex justify-content-start align-items-center">
-                <p class="my-0 mx-1" data-count-like="${comment.like.love}">${comment.like.love}</p>
-                <i class="me-1 ${likes.has(comment.uuid) ? 'fa-solid fa-heart text-danger' : 'fa-regular fa-heart'}"></i>
-            </div>
+        <button style="font-size: 0.8rem;" onclick="like.like(this)" data-uuid="${comment.uuid}" class="btn btn-sm btn-outline-${theme.isDarkMode('light', 'dark')} ms-auto rounded-3 p-0 d-flex justify-content-start align-items-center" data-offline-disabled>
+            <span class="my-0 mx-1" data-count-like="${comment.like.love}">${comment.like.love}</span>
+            <i class="me-1 ${likes.has(comment.uuid) ? 'fa-solid fa-heart text-danger' : 'fa-regular fa-heart'}"></i>
         </button>`;
     };
 

diff --git a/js/like.js b/js/like.js
@@ -20,8 +20,8 @@ export const like = (() => {
     const like = async (button) => {
         const id = button.getAttribute('data-uuid');
 
-        const heart = button.firstElementChild.lastElementChild;
-        const info = button.firstElementChild.firstElementChild;
+        const info = button.firstElementChild;
+        const heart = button.lastElementChild;
 
         button.disabled = true;