feat(charts/dex): use updated HorizontalPodAutoscaler API Version #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott McCullough <mcculloughsco12@gmail.com>
Signed-off-by: Scott McCullough <mcculloughsco12@gmail.com>
|
When you have some time @sagikazarmark it would be great to get a review on this. |
sagikazarmark
approved these changes
Jun 27, 2023
|
Thanks for the ping and patience @sgmccullough! LGTMT |
|
Fantastic, thank you!! |
sgmccullough
added a commit
to sgmccullough/dex-helm-charts
that referenced
this pull request
Jun 27, 2023
3 tasks
sgmccullough
added a commit
to sgmccullough/dex-helm-charts
that referenced
this pull request
Jun 27, 2023
Signed-off-by: GitHub <noreply@github.com>
nabokihms
added a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use updated autoscaling API Version for HorizontalPodAutoscaler.
What this PR does / why we need it
The
autoscaling/v2beta1API version of HorizontalPodAutoscaler isn't served on K8s versions >=1.25. The Dex chart should support the newer version of the API,autoscaling/v2which is available on K8s versions >=1.23.Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs