Add spec.revisionHistoryLimit config possibility for Deployment resource #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhoyer thanks for the PR. Could you please update the doc? |
|
Ok. Got it. I forgot to run |
Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>
Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>
Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>
mhoyer
force-pushed
the
add-revistion-history-limit-option
branch
from
71fab0f
to
0139bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Especially when using GitOps approach to deploy DexIdP it makes not real sense to keep revisions of the deployments as those are actually kind of persisted inside the underlying SCM, which drives the deployment and its history.
What this PR does / why we need it
It simply adds the possibility to configure the
revisionHistoryLimitproperty of theDeploymentresource template, but keeps the default to10.Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs