feat: Add ability to deploy extra manifests #117
Conversation
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
force-pushed
the
feature/extra-manifests
branch
from
bdd6777
to
157ca1a
Compare
There was a problem hiding this comment.
Thanks for the contribution @mkilchhofer !
I made a few comments. Also, please run make docs in the repo to regenerate readme. Thanks!
| @@ -328,3 +328,21 @@ networkPolicy: | |||
| # ports: | |||
| # - port: 636 | |||
| # protocol: TCP | |||
|
|
|||
| # -- List of extra manifests to deploy. Will be passed through `tpl` to support templating | |||
There was a problem hiding this comment.
| # -- List of extra manifests to deploy. Will be passed through `tpl` to support templating | |
| # -- List of extra manifests to deploy. Will be passed through `tpl` to support templating. |
Nit
| # kind: ExternalSecret | ||
| # metadata: | ||
| # name: my-external-secret | ||
| # namespace: '{{ .Release.Namespace }}' |
There was a problem hiding this comment.
Out of curiosity: is the namespace really necessary? Wouldn't helm take care of that? If it's not necessary, I'd probably leave it out of the example as well.
There was a problem hiding this comment.
I just wanted to highlight that due to usage of the tpl function it is possible to use helm internal functions.
There was a problem hiding this comment.
How about name: {{ .Release.Name }} or something like that instead?
|
Any particular reason this was closed? Or just lack of time? Just curious if the change is resubmitted we can move it through. |
IMHO this change is defintively useful. But for me resp. my use case I dont need this feature anymore since I now create an umbrella helm chart for every app. @sagikazarmark what is your opinion here? |
Overview
It is common now that helm charts offer the ability to deploy custom resources along the application. It is especially useful for managing Secrets (eg. via external-secrets.io / Secrets Store CSI Driver) or deploying more granular NetworkPolicy (eg. CiliumNetworkPolicy).
Charts in the community that supports this:
What this PR does / why we need it
Add new parameter which allows injecting arbitrary resources.
Special notes for your reviewer
none
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs