fix(charts/dex): Helm - Versioning #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Galos <mihai.galos@rbinternational.com>
Signed-off-by: Mihai Galos <mihai.galos@rbinternational.com>
Signed-off-by: Mihai Galos <mihai.galos@rbinternational.com>
sagikazarmark
approved these changes
Apr 19, 2024
sagikazarmark
requested changes
Apr 19, 2024
Signed-off-by: Mihai Galos <mihai.galos@rbinternational.com>
|
Hi @sagikazarmark, is this now ready? |
Signed-off-by: Mihai Galos <mihai@galos.one>
|
Up @sagikazarmark - any news here? |
sagikazarmark
approved these changes
Jul 22, 2024
sagikazarmark
requested changes
Jul 22, 2024
There was a problem hiding this comment.
This won't fix #125
The v prefix should be added to appVersion.
Prefixing also needs to be removed from here: https://github.com/dexidp/helm-charts/blob/master/charts/dex/templates/deployment.yaml#L59
Finally, this change should result in a minor chart version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adapts the versioning of the Helm chart to make it consistent with other projects and its internally used comments for versioning.
What this PR does / why we need it
Fixes: #125.
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs